handle deleted integrations gracefully in report generation#37
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents a panic during report generation when an AWS integration has been deleted by adding a nil check.
- Adds a branch to return early if the fetched integration is
nil. - Returns
nil, nilin that scenario.
Comments suppressed due to low confidence (1)
backend/app/report.go:266
- There’s no test covering the scenario where the AWS integration is deleted mid-generation. Adding a unit or integration test for this branch will ensure the nil case continues to be handled safely.
} else if integration == nil {
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get aws integration: %w", err) | ||
| } else if integration == nil { | ||
| return nil, nil |
There was a problem hiding this comment.
Returning a nil report and nil error can lead to silent failures or unexpected behavior downstream. Consider returning a descriptive error or an empty but valid report object to make this case explicit.
Suggested change
| return nil, nil | |
| return nil, fmt.Errorf("integration not found for AWSIntegrationId: %s", input.AWSIntegrationId) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Avoids a panic that would occur if a user deleted an integration in the middle of report generation.