Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds CloudWatch alarms for DLQs and configures SNS notifications for regional alerts.
- Import and utilize CloudWatch and SNS modules.
- Create SNS topics and attach alarm actions to DLQs.
- Update README.md with details on regional alarm subscriptions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aws/lib/regional-stack.ts | Adds SNS topic creation and CloudWatch alarms for dead letter queues. |
| aws/README.md | Updates documentation to include alarm subscription details. |
Comments suppressed due to low confidence (1)
aws/lib/regional-stack.ts:266
- [nitpick] The DLQ name for the Stripe event handler is hard-coded as 'CloudSnitchStripeEventHandler-DLQ', while the other DLQ uses a template literal. Consider using a consistent naming convention across DLQs for clarity.
const dlq = new sqs.Queue(this, 'StripeEventHandlerDLQ', {
| const dlq = new sqs.Queue(this, 'DeadLetterQueue', { | ||
| queueName: `${queueName}-DLQ`, | ||
| }); | ||
| const dlqAlarm = new cw.Alarm(this, 'DeadLetterQueueAlarm', { |
There was a problem hiding this comment.
[nitpick] Consider adding a 'description' field to the CloudWatch alarm configuration to provide more context for what triggers the alarm, which can aid in troubleshooting and monitoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Adds CloudWatch alarms for the dead letter queues.
Related Issues
#28