Skip to content

add cloudwatch dashboard#30

Merged
ccbrown merged 1 commit intomainfrom
cloudwatch-dashboard
Apr 30, 2025
Merged

add cloudwatch dashboard#30
ccbrown merged 1 commit intomainfrom
cloudwatch-dashboard

Conversation

@ccbrown
Copy link
Owner

@ccbrown ccbrown commented Apr 30, 2025

What It Does

Adds a CloudWatch dashboard to the CDK deployment.

Related Issues

Copilot AI review requested due to automatic review settings April 30, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a CloudWatch dashboard to the CDK deployment for enhanced observability.

  • Introduces new properties (allRegions and envSlug) in global-apex-stack.ts and environment.ts to support multi-region metrics.
  • Adds a custom Dashboard construct to create several GraphWidgets for API requests, API errors, Lambda invocations, maximum Lambda duration, and SQS oldest message age.
  • Updates documentation in README.md to reflect the new observability features.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
aws/lib/global-apex-stack.ts Added Dashboard construct with multi-region CloudWatch metrics.
aws/lib/environment.ts Updated GlobalApexStack initialization to pass new dashboard props.
aws/README.md Added Observability section describing the new CloudWatch dashboard.
Comments suppressed due to low confidence (2)

aws/lib/global-apex-stack.ts:87

  • The metric label for API Errors uses only the region name which may cause ambiguity between 4xx and 5xx error metrics. Consider appending the metric type (e.g., ${region}-${metric}) to the label for clearer identification.
for (const metric of ['4xx', '5xx']) {

aws/lib/global-apex-stack.ts:49

  • [nitpick] Naming the Construct as 'Dashboard' could be confusing since it shares the same name as the CloudWatch Dashboard object. Consider renaming the construct (e.g., 'CloudWatchDashboard') to differentiate it.
const dashboard = new cw.Dashboard(this, 'Dashboard', {

@ccbrown ccbrown merged commit 1241995 into main Apr 30, 2025
3 checks passed
@ccbrown ccbrown deleted the cloudwatch-dashboard branch April 30, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant