add syntax highlighting and new article on tag-based permissions#24
Merged
add syntax highlighting and new article on tag-based permissions#24
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces syntax highlighting support and styles adjustments alongside a new article on tag-based permissions. Key changes include:
- Adding a new SyntaxHighlighter component to render code blocks.
- Updating Markdown blockquote styling.
- Enhancing articles with author information and adding a new tag-based permissions article.
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/index.tsx | Export added for the new SyntaxHighlighter component. |
| frontend/src/components/SyntaxHighlighter.tsx | New component that registers languages and applies syntax highlighting. |
| frontend/src/components/Markdown.tsx | Updated blockquote styling to use a concise "quote" class. |
| frontend/src/app/(user-area)/teams/[teamId]/Rules.tsx | Replaced |
| frontend/src/app/(public-area)/page.tsx | Adjusted layout and spacing for feature links. |
| frontend/src/app/(public-area)/articles/page.tsx | Added author image display for articles. |
| frontend/src/app/(public-area)/articles/index.tsx | Included the new article on tag-based permissions with proper metadata. |
| frontend/src/app/(public-area)/articles/how-to-allow-aws-principals-to-modify-only-resources... | New detailed article describing tag-based permissions implementation. |
| frontend/src/app/(public-area)/articles/capital-one-data-breach.tsx | Added author information to the article metadata. |
| frontend/src/app/(public-area)/articles/[slug]/page.tsx | Enhanced article page layout including navigation and author display. |
Files not reviewed (3)
- frontend/package-lock.json: Language not supported
- frontend/package.json: Language not supported
- frontend/src/app/globals.css: Language not supported
Comments suppressed due to low confidence (2)
frontend/src/components/SyntaxHighlighter.tsx:10
- [nitpick] Consider updating the 'language' prop type to allow additional languages (e.g. using a string union or extended type) if future syntax support is anticipated.
language: 'bash' | 'json';
frontend/src/components/Markdown.tsx:32
- [nitpick] Verify that the new 'quote' class applies the intended styling and accessibility standards consistently across different browsers and contexts.
return <blockquote className="quote">{children}</blockquote>;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does