Skip to content

add syntax highlighting and new article on tag-based permissions#24

Merged
ccbrown merged 1 commit intomainfrom
tagging-article
Apr 21, 2025
Merged

add syntax highlighting and new article on tag-based permissions#24
ccbrown merged 1 commit intomainfrom
tagging-article

Conversation

@ccbrown
Copy link
Owner

@ccbrown ccbrown commented Apr 21, 2025

What It Does

  • Syntax highlighting for code blocks
  • Articles polish
  • New article on tag-based permissions

Copilot AI review requested due to automatic review settings April 21, 2025 22:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces syntax highlighting support and styles adjustments alongside a new article on tag-based permissions. Key changes include:

  • Adding a new SyntaxHighlighter component to render code blocks.
  • Updating Markdown blockquote styling.
  • Enhancing articles with author information and adding a new tag-based permissions article.

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/components/index.tsx Export added for the new SyntaxHighlighter component.
frontend/src/components/SyntaxHighlighter.tsx New component that registers languages and applies syntax highlighting.
frontend/src/components/Markdown.tsx Updated blockquote styling to use a concise "quote" class.
frontend/src/app/(user-area)/teams/[teamId]/Rules.tsx Replaced
 with SyntaxHighlighter for a policy preview.
frontend/src/app/(public-area)/page.tsx Adjusted layout and spacing for feature links.
frontend/src/app/(public-area)/articles/page.tsx Added author image display for articles.
frontend/src/app/(public-area)/articles/index.tsx Included the new article on tag-based permissions with proper metadata.
frontend/src/app/(public-area)/articles/how-to-allow-aws-principals-to-modify-only-resources... New detailed article describing tag-based permissions implementation.
frontend/src/app/(public-area)/articles/capital-one-data-breach.tsx Added author information to the article metadata.
frontend/src/app/(public-area)/articles/[slug]/page.tsx Enhanced article page layout including navigation and author display.
Files not reviewed (3)
  • frontend/package-lock.json: Language not supported
  • frontend/package.json: Language not supported
  • frontend/src/app/globals.css: Language not supported
Comments suppressed due to low confidence (2)

frontend/src/components/SyntaxHighlighter.tsx:10

  • [nitpick] Consider updating the 'language' prop type to allow additional languages (e.g. using a string union or extended type) if future syntax support is anticipated.
    language: 'bash' | 'json';

frontend/src/components/Markdown.tsx:32

  • [nitpick] Verify that the new 'quote' class applies the intended styling and accessibility standards consistently across different browsers and contexts.
return <blockquote className="quote">{children}</blockquote>;

@ccbrown ccbrown merged commit 59ae9c8 into main Apr 21, 2025
3 checks passed
@ccbrown ccbrown deleted the tagging-article branch April 21, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant