Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR polishes the SCP management UI and updates error messages for access report generation.
- Improves UI styling in success and error messages
- Enhances Dialog and ChipEditor components for better UX
- Refines error messaging in AWS access report generation in the backend
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/models/reports.ts | Returns API response in report generation flow |
| frontend/src/models/aws.ts | Adds a new method to fetch AWS access reports by team and account ID |
| frontend/src/components/SuccessMessage.tsx | Adjusts styling for success notifications |
| frontend/src/components/ErrorMessage.tsx | Adjusts styling for error notifications |
| frontend/src/components/Dialog.tsx | Introduces a size prop and adjusts Dialog layout |
| frontend/src/components/ChipEditor.tsx | Enhances ChipEditor with altLabel support and refactors InlineCombobox |
| frontend/src/app/(user-area)/teams/[teamId]/settings/members/page.tsx | Updates layout and table styling on team members page |
| frontend/src/app/(user-area)/teams/[teamId]/page.tsx | Updates Dialog component usage by including the size prop |
| frontend/src/app/(user-area)/teams/[teamId]/Rules.tsx | Updates ChipEditor usage with region/service alternate labels |
| backend/app/aws_integration.go | Enhances error message detail for AWS access report generation |
| return nil, s.SanitizedError(fmt.Errorf("failed to generate access report")) | ||
| var message string | ||
| if output.ErrorDetails != nil && output.ErrorDetails.Message != nil { | ||
| message = *output.ErrorDetails.Message |
There was a problem hiding this comment.
Consider providing a default fallback value for 'message' when 'output.ErrorDetails.Message' is nil to ensure that error messages remain informative.
Suggested change
| message = *output.ErrorDetails.Message | |
| message = *output.ErrorDetails.Message | |
| } else { | |
| message = "No error details provided." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Minor UI improvements, especially to SCP management.
Also adds detail to access report generation error messages.