Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new UI for managing SCPs, enabling manual editing of region and service allowlists. Key changes include:
- Adding a new RuleSet model and related types for SCP manipulation.
- Creating new components and hooks (ChipEditor, useManagedAwsScp, Rules) to support SCP management.
- Integrating SCP functionality into the overall AWS management UI.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/rules.ts | Introduces the RuleSet class and relevant types for managing region and service allowlists. |
| frontend/src/models/aws.ts | Adds support for managed SCPs with new state entries and API actions. |
| frontend/src/hooks.ts | Adds the useManagedAwsScp hook for fetching managed SCP information. |
| frontend/src/components/index.tsx | Exports the new ChipEditor component. |
| frontend/src/components/SuccessMessage.tsx | Updates UI styling (success message background color changed to bg-emerald). |
| frontend/src/components/ChipEditor.tsx | Introduces the ChipEditor component for interactive allowlist management. |
| frontend/src/app/(user-area)/teams/[teamId]/page.tsx | Integrates the SCP management UI via a new Rules dialog and associated controls. |
| frontend/src/app/(user-area)/teams/[teamId]/Rules.tsx | Provides a dedicated interface for editing and previewing SCPs applied to AWS accounts. |
| frontend/src/app/(user-area)/teams/[teamId]/MapOverlays.tsx | Removes an extraneous class ('baz') from the marker className string. |
| frontend/src/app/(public-area)/articles/[slug]/page.tsx | Adjusts Link formatting for improved readability. |
| frontend/scripts/gather_aws_service_info.py | Adds a new script to gather AWS service info using Organizations and IAM clients. |
Files not reviewed (1)
- frontend/src/app/globals.css: Language not supported
Comments suppressed due to low confidence (1)
frontend/src/rules.ts:69
- [nitpick] Consider renaming the method 'equal' to 'equals' for improved clarity in indicating its purpose of comparing RuleSet instances.
equal(other: RuleSet): boolean {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Adds a UI for managing SCPs. This UI allows manually editing region and service allowlists.
Nothing too smart yet (no recommendations), but it works well.
Related Issues
#6