Skip to content

add scp management ui#20

Merged
ccbrown merged 2 commits intomainfrom
mvp-scp-management
Apr 20, 2025
Merged

add scp management ui#20
ccbrown merged 2 commits intomainfrom
mvp-scp-management

Conversation

@ccbrown
Copy link
Owner

@ccbrown ccbrown commented Apr 20, 2025

What It Does

Adds a UI for managing SCPs. This UI allows manually editing region and service allowlists.

Nothing too smart yet (no recommendations), but it works well.

Related Issues

#6

Copilot AI review requested due to automatic review settings April 20, 2025 06:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new UI for managing SCPs, enabling manual editing of region and service allowlists. Key changes include:

  • Adding a new RuleSet model and related types for SCP manipulation.
  • Creating new components and hooks (ChipEditor, useManagedAwsScp, Rules) to support SCP management.
  • Integrating SCP functionality into the overall AWS management UI.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/rules.ts Introduces the RuleSet class and relevant types for managing region and service allowlists.
frontend/src/models/aws.ts Adds support for managed SCPs with new state entries and API actions.
frontend/src/hooks.ts Adds the useManagedAwsScp hook for fetching managed SCP information.
frontend/src/components/index.tsx Exports the new ChipEditor component.
frontend/src/components/SuccessMessage.tsx Updates UI styling (success message background color changed to bg-emerald).
frontend/src/components/ChipEditor.tsx Introduces the ChipEditor component for interactive allowlist management.
frontend/src/app/(user-area)/teams/[teamId]/page.tsx Integrates the SCP management UI via a new Rules dialog and associated controls.
frontend/src/app/(user-area)/teams/[teamId]/Rules.tsx Provides a dedicated interface for editing and previewing SCPs applied to AWS accounts.
frontend/src/app/(user-area)/teams/[teamId]/MapOverlays.tsx Removes an extraneous class ('baz') from the marker className string.
frontend/src/app/(public-area)/articles/[slug]/page.tsx Adjusts Link formatting for improved readability.
frontend/scripts/gather_aws_service_info.py Adds a new script to gather AWS service info using Organizations and IAM clients.
Files not reviewed (1)
  • frontend/src/app/globals.css: Language not supported
Comments suppressed due to low confidence (1)

frontend/src/rules.ts:69

  • [nitpick] Consider renaming the method 'equal' to 'equals' for improved clarity in indicating its purpose of comparing RuleSet instances.
equal(other: RuleSet): boolean {

@ccbrown ccbrown merged commit 7dcd362 into main Apr 20, 2025
3 checks passed
@ccbrown ccbrown deleted the mvp-scp-management branch April 20, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant