Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AWS integration report generation to include the new field for managing SCPs and renames functions and input types accordingly.
- Renames queueAWSIntegrationReportGeneration functions and input types to doReconAndQueueAWSIntegrationReportGeneration to better reflect their behavior.
- Populates the new CanManageSCPs field for AWS integration recon reports.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/app/report.go | Renamed functions and input types; passed integration.ManageSCPs to CanManageSCPs. |
| backend/app/aws_integration.go | Updated function calls and added CanManageSCPs to recon input struct. |
Comments suppressed due to low confidence (2)
backend/app/report.go:83
- [nitpick] The new function name doReconAndQueueAWSIntegrationReportGeneration is quite long; consider shortening it for clarity while preserving its descriptive nature.
if err := a.doReconAndQueueAWSIntegrationReportGeneration(ctx, doReconAndQueueAWSIntegrationReportGenerationInput{
backend/app/aws_integration.go:323
- [nitpick] Ensure that the naming convention between the source field (ManageSCPs) and the target field (CanManageSCPs) is consistent and clearly documented.
CanManageSCPs bool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Minor renaming, and populating newly added and previously unset field in AWS integration recon.