Skip to content

set canManageScps field for accounts#19

Merged
ccbrown merged 1 commit intomainfrom
set-can-manage-scps-field
Apr 20, 2025
Merged

set canManageScps field for accounts#19
ccbrown merged 1 commit intomainfrom
set-can-manage-scps-field

Conversation

@ccbrown
Copy link
Owner

@ccbrown ccbrown commented Apr 20, 2025

What It Does

Minor renaming, and populating newly added and previously unset field in AWS integration recon.

Copilot AI review requested due to automatic review settings April 20, 2025 00:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AWS integration report generation to include the new field for managing SCPs and renames functions and input types accordingly.

  • Renames queueAWSIntegrationReportGeneration functions and input types to doReconAndQueueAWSIntegrationReportGeneration to better reflect their behavior.
  • Populates the new CanManageSCPs field for AWS integration recon reports.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backend/app/report.go Renamed functions and input types; passed integration.ManageSCPs to CanManageSCPs.
backend/app/aws_integration.go Updated function calls and added CanManageSCPs to recon input struct.
Comments suppressed due to low confidence (2)

backend/app/report.go:83

  • [nitpick] The new function name doReconAndQueueAWSIntegrationReportGeneration is quite long; consider shortening it for clarity while preserving its descriptive nature.
if err := a.doReconAndQueueAWSIntegrationReportGeneration(ctx, doReconAndQueueAWSIntegrationReportGenerationInput{

backend/app/aws_integration.go:323

  • [nitpick] Ensure that the naming convention between the source field (ManageSCPs) and the target field (CanManageSCPs) is consistent and clearly documented.
CanManageSCPs    bool

@ccbrown ccbrown merged commit 4202182 into main Apr 20, 2025
3 checks passed
@ccbrown ccbrown deleted the set-can-manage-scps-field branch April 20, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant