Skip to content

vastly improved integration settings page#16

Merged
ccbrown merged 1 commit intomainfrom
integration-settings-improvements
Apr 19, 2025
Merged

vastly improved integration settings page#16
ccbrown merged 1 commit intomainfrom
integration-settings-improvements

Conversation

@ccbrown
Copy link
Owner

@ccbrown ccbrown commented Apr 19, 2025

What It Does

This vastly improves the UI on the integration settings page, showing way more detail and allowing for editing of integration names.

It also adds UI elements to enable and show the status of SCP management.

Related Issues

Copilot AI review requested due to automatic review settings April 19, 2025 03:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the integration settings page by updating the AWS integration model, UI components, and cloudformation templates to support improved integration details and new SCP management functionality. Key changes include:

  • Introduction of the updateIntegration method and corresponding API input type.
  • Updates to UI components and styling for consistency (e.g. label classes).
  • Upgrading the integration revision (v2 → v3) and adding new parameters/mappings in the CloudFormation template.

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/models/aws.ts Added updateIntegration method and imported UpdateAWSIntegrationInput.
frontend/src/integration.ts Incremented REVISION constant to 3.
frontend/src/components/Tooltip.tsx, TextField.tsx, TextArea.tsx, Select.tsx, Checkbox.tsx Updated component props and styling for label consistency.
frontend/src/app/(user-area)/teams/[teamId]/settings/*.tsx Updated UI elements and dialogs for integration management and settings with consistent styling.
frontend/public/integration-v3.cfn.yaml Upgraded the CFN template to v3 with new SCP management parameters and conditionals.
backend/api/aws_integration.go Mapped RoleARN to RoleArn in the integration conversion.
aws/lib/regional-stack.ts Updated the integration template file reference to integration-v3.cfn.yaml.
Files not reviewed (1)
  • frontend/src/app/globals.css: Language not supported
Comments suppressed due to low confidence (2)

frontend/public/integration-v3.cfn.yaml:127

  • Ensure that automated tests cover both cases for the new AllowSCPManagement parameter to verify that the correct IAM policies are attached based on its value.
# If you specify that you want to allow Cloud Snitch to manage service control policies, we

frontend/src/models/aws.ts:106

  • Verify that the new API call updateAWSIntegration and the input type UpdateAWSIntegrationInput are fully supported by the backend API to prevent integration issues.
async updateIntegration(payload: { integrationId: string; input: UpdateAWSIntegrationInput }, state) {

@ccbrown ccbrown merged commit 4bf5ef5 into main Apr 19, 2025
3 checks passed
@ccbrown ccbrown deleted the integration-settings-improvements branch April 19, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant