Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the integration settings page by updating the AWS integration model, UI components, and cloudformation templates to support improved integration details and new SCP management functionality. Key changes include:
- Introduction of the updateIntegration method and corresponding API input type.
- Updates to UI components and styling for consistency (e.g. label classes).
- Upgrading the integration revision (v2 → v3) and adding new parameters/mappings in the CloudFormation template.
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/models/aws.ts | Added updateIntegration method and imported UpdateAWSIntegrationInput. |
| frontend/src/integration.ts | Incremented REVISION constant to 3. |
| frontend/src/components/Tooltip.tsx, TextField.tsx, TextArea.tsx, Select.tsx, Checkbox.tsx | Updated component props and styling for label consistency. |
| frontend/src/app/(user-area)/teams/[teamId]/settings/*.tsx | Updated UI elements and dialogs for integration management and settings with consistent styling. |
| frontend/public/integration-v3.cfn.yaml | Upgraded the CFN template to v3 with new SCP management parameters and conditionals. |
| backend/api/aws_integration.go | Mapped RoleARN to RoleArn in the integration conversion. |
| aws/lib/regional-stack.ts | Updated the integration template file reference to integration-v3.cfn.yaml. |
Files not reviewed (1)
- frontend/src/app/globals.css: Language not supported
Comments suppressed due to low confidence (2)
frontend/public/integration-v3.cfn.yaml:127
- Ensure that automated tests cover both cases for the new AllowSCPManagement parameter to verify that the correct IAM policies are attached based on its value.
# If you specify that you want to allow Cloud Snitch to manage service control policies, we
frontend/src/models/aws.ts:106
- Verify that the new API call updateAWSIntegration and the input type UpdateAWSIntegrationInput are fully supported by the backend API to prevent integration issues.
async updateIntegration(payload: { integrationId: string; input: UpdateAWSIntegrationInput }, state) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
This vastly improves the UI on the integration settings page, showing way more detail and allowing for editing of integration names.
It also adds UI elements to enable and show the status of SCP management.
Related Issues