Skip to content

video suffix default value#130

Open
to-bee wants to merge 1 commit intocbopp-art:v2.4.xfrom
to-bee:v2.4.1
Open

video suffix default value#130
to-bee wants to merge 1 commit intocbopp-art:v2.4.xfrom
to-bee:v2.4.1

Conversation

@to-bee
Copy link
Copy Markdown

@to-bee to-bee commented Apr 27, 2017

for example facebook videos don't have a suffix ending but normally the type is mp4

@cbopp-art
Copy link
Copy Markdown
Owner

Can't you just use option type to force open as video?

type: 'video'

see http://cornel.bopp-art.com/lightcase/documentation/#property-type

@to-bee
Copy link
Copy Markdown
Author

to-bee commented Apr 27, 2017 via email

@cbopp-art
Copy link
Copy Markdown
Owner

I am not sure if I fully understand your issue. Could you may provide any example, fiddle or so that we can check what actually goes wrong with implementation?
Thanks in advance.

@to-bee
Copy link
Copy Markdown
Author

to-bee commented May 1, 2017 via email

@cbopp-art
Copy link
Copy Markdown
Owner

cbopp-art commented May 8, 2017

Thanks a lot for the example!
The real cause of this issue are actually the parameters which are appended to the url.
Thus I think that the right solution to fix it should be this in function _getFileUrlSuffix:

  return re.exec(url.split('?')[0].toLowerCase())[1];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants