Flask Backend Module for WebCAS #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/webSCAS into feat/flaskBackend
pnijhara
suggested changes
May 21, 2020
Contributor
pnijhara
left a comment
pnijhara
left a comment
There was a problem hiding this comment.
LGTM! Please see my comments and make those changes.
run.py
Outdated
| if __name__ == '__main__': | ||
| app.run() | ||
|
|
||
| ############################################################################### |
scasBackend/__init__.py
Outdated
| @@ -0,0 +1,82 @@ | |||
|
|
|||
| # Imports | |||
| ########## | |||
Contributor
There was a problem hiding this comment.
Remove unnecessary octothorps
scasBackend/__init__.py
Outdated
| ############################################################################### | ||
|
|
||
|
|
||
| # Pre/Post Request Processing |
Contributor
There was a problem hiding this comment.
If you want to write proper comments then replace these octothorps with proper comments.
Contributor
|
@jayanthchandra jinja sounds good to me! |
Contributor
|
LGTM! lets wait for @akram-mohammed's respose. |
pnijhara
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
As mentioned on Readme, the module is written in Flask.This is the base module which i could write, the ui part could be done using jinja templates. If i have missed anything, let me know :)
If this development is already done through, then you close this request.