Skip to content

engine_cart:prepare is idempotent when stanza is current #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dazza-codes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

engine_cart:prepare is idempotent when stanza is current #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/engine_cart.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,14 @@ class << self
def self.check_for_gemfile_stanza
return unless File.exist? 'Gemfile'

unless File.readlines('Gemfile').grep(/#{EngineCart.gemfile_stanza_check_line}/).any?
unless gemfile_stanza_current?
Bundler.ui.warn "[EngineCart] For better results, consider updating the EngineCart stanza in your Gemfile with:\n\n"
Bundler.ui.warn EngineCart.gemfile_stanza_text
end
end

def self.gemfile_stanza_current?
return false unless File.exist? 'Gemfile'
File.readlines('Gemfile').grep(/#{EngineCart.gemfile_stanza_check_line}/).any?
end
end
14 changes: 8 additions & 6 deletions lib/engine_cart/tasks/engine_cart.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ require 'engine_cart'
namespace :engine_cart do

desc "Prepare a gem for using engine_cart"
task :prepare do
require 'generators/engine_cart/install_generator'
generator = EngineCart::InstallGenerator.new
generator.create_test_app_templates
generator.ignore_test_app
generator.add_gemfile_include
task :prepare, [:force] do |t, args|
if !EngineCart.gemfile_stanza_current? || args[:force]
require 'generators/engine_cart/install_generator'
generator = EngineCart::InstallGenerator.new
generator.create_test_app_templates
generator.ignore_test_app
generator.add_gemfile_include
end
end

task :setup do
Expand Down