Skip to content

init config from archive#5

Open
tclavier wants to merge 1 commit intocbeer:masterfrom
deliverous:master
Open

init config from archive#5
tclavier wants to merge 1 commit intocbeer:masterfrom
deliverous:master

Conversation

@tclavier
Copy link

Initialize config directory from official archive if not exist.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the upstream image launches apache slightly differently:

https://github.com/tutumcloud/tutum-docker-php/blob/master/run.sh#L3-5

Instead of launching apache ourself, could we call their run script after doing our bit of configuration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in upstream run.sh script, they load environments ... like /etc/init.d/apache2 do that, and they start apache in foreground mode. I prefer used Ubuntu / Debian apache maintainer script and follow evolution made by this team.
And yes, we can start run.sh given by tutum team after initialization ... but tutum team is more little and less reactive than Debian and Ubuntu community :-D

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to replace the base image if you can recommend a better one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we can just change run script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants