Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from the deprecated useTranslation hook to the modern useTranslate hook from Refine, and reorganizes the translation key structure for better maintainability and consistency.
- Replaces all instances of
useTranslationwithuseTranslateacross the codebase - Restructures translation keys to use a hierarchical dot notation format (e.g.,
boats.add.titleinstead ofAddBoat.title) - Adds new boat management features including rename functionality and a delete confirmation modal
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/interventions/pages/* | Updates translation hook usage and key structure for intervention pages |
| src/equipments/pages/* | Updates translation hook usage for equipment pages |
| src/boats/pages/* | Updates translation hook and adds enhanced boat management features |
| src/boats/components/* | Updates translation hook usage and adds new BoatDeleteButton component |
| src/auth/* | Updates translation hook usage for authentication components |
| src/core/components/app-provider.tsx | Adds notification provider configuration |
| public/locales/*.json | Restructures translation keys to use hierarchical dot notation |
| .github/copilot-instructions.md | Adds comprehensive project documentation for AI agents |
| }); | ||
|
|
||
| const handleOnFinish = (values: {}) => { | ||
| const handleOnFinish = (values: Record<string, unknown>) => { |
There was a problem hiding this comment.
The parameter type Record<string, unknown> is too generic for form values. Consider creating a proper interface for the boat form values to improve type safety and API clarity.
Suggested change
| const handleOnFinish = (values: Record<string, unknown>) => { | |
| const handleOnFinish = (values: BoatFormValues) => { |
cballevre
force-pushed
the
feat/manage-boat
branch
from
6dbc06c to
84bf7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.