Vertex data packing #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb341
commented
Mar 21, 2025
| chunk_position: Vec3, | ||
| mesh_type: MeshType, | ||
| material_handle: Handle<StandardMaterial>, | ||
| material_handle: Handle<ExtendedMaterial<StandardMaterial, MyExtension>>, |
Owner
Author
There was a problem hiding this comment.
Define Type Alias for the material
Suggested change
| material_handle: Handle<ExtendedMaterial<StandardMaterial, MyExtension>>, | |
| material_handle: Handle<ChunkMaterial>, |
assets/shaders/my_material.glsl
Outdated
Comment on lines
26
to
27
| @location(0) position: vec3<f32>, | ||
| @location(1) blend_color: vec4<f32>, |
Owner
Author
There was a problem hiding this comment.
Use packed data
Suggested change
| @location(0) position: vec3<f32>, | |
| @location(1) blend_color: vec4<f32>, | |
| @location(0) packed_data: f32, |
cb341
commented
Mar 21, 2025
src/client/terrain/materials.rs
Outdated
Comment on lines
10
to
13
| // We need to ensure that the bindings of the base material and the extension do not conflict, | ||
| // so we start from binding slot 100, leaving slots 0-99 for the base material. | ||
| #[uniform(100)] | ||
| pub quantize_steps: u32, |
Owner
Author
There was a problem hiding this comment.
No parameter needed, wie just override the vertex shader
Suggested change
| // We need to ensure that the bindings of the base material and the extension do not conflict, | |
| // so we start from binding slot 100, leaving slots 0-99 for the base material. | |
| #[uniform(100)] | |
| pub quantize_steps: u32, |
Owner
Author
|
This PR has been abandoned in favour of implementing own RayTracer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertex Data Packing
Currently the terrain uses up a lot of memory. This could be the cause for all the lag spikes when rendering the world.
One optimization is reducing the amount of data each vertex holds by packing multiple attributes into one number and extracting the individual values in a vertex shader, adding a little overhead to every render.
The following plan is based on the Information Theory class from ZHAW: