Skip to content

Conversation

@aaronfischer
Copy link
Contributor

@aaronfischer aaronfischer commented Jul 15, 2016

What does this pull request do?

Sets up gh-pages for demo URL.

What are the relevant issues?

#56

Any background context you want to provide?

Depends upon #54

Definition of Done:

Each should be selected to indicate consideration for applicability and/or completion.

  • Does this PR fully satisfy the scope as outlined in the referenced issue(s)?
  • Is there appropriate test coverage?
  • Is static analysis resulting in a satisfactory score?
  • If adding new dependencies, does pip requirements need to be updated?
  • Has the change log been updated?

@aaronfischer
Copy link
Contributor Author

@morgan
Super stoked to have a demo URL! (even if the actual demo site needs some finessing)

http://caxiam.github.io/ember-tabular/

So I've checked the documentation on https://github.com/cibernox/ember-cli-yuidoc#environment-specific-generation and I have it setup to generate /docs/* on development and production, however I can't seem to access this on the the gh-pages url: http://caxiam.github.io/ember-tabular/docs/index.html

@aaronfischer
Copy link
Contributor Author

Since gh-pages works by using the actual repo files... I'm assuming I'll need to alter the .gitignore on https://github.com/caxiam/ember-tabular/blob/gh-pages/.gitignore and remove the "/docs/*" directory so that when the build happens this directory is committed and added to gh-pages branch for deployment?

@morgan
Copy link
Member

morgan commented Jul 15, 2016

@aaronfischer Is there a way to build just for deploy?

Super cool seeing it up there! Can't wait to wrap it with a slick theme!

@aaronfischer
Copy link
Contributor Author

@morgan If the /docs/* directory is not committed to the gh-pages branch then I don't think there is any way to view it since those specific files are used to serve up the site.

I can alter the specific gh-pages branch .gitignore though so it doesn't effect the main "addon" related branches, that should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants