Skip to content

Dynamic columns no config persist column order #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
morgan wants to merge 130 commits into
base: master
Choose a base branch
from
Open

Dynamic columns no config persist column order #109

morgan wants to merge 130 commits into from

Conversation

@morgan
Copy link
Member

@morgan morgan commented Apr 22, 2022

What does this pull request do?

What are the relevant issues?

Any background context you want to provide?

Definition of Done:

Each should be selected to indicate consideration for applicability and/or completion.

  • Does this PR fully satisfy the scope as outlined in the referenced issue(s)?
  • Is there appropriate test coverage?
  • Is static analysis resulting in a satisfactory score?
  • If adding new dependencies, does pip requirements need to be updated?
  • Has the change log been updated?

aaronfischer added 30 commits May 25, 2017 15:57
@aaronfischer
Setting up changelog for v0.2.0
f089918
@aaronfischer
Correct changelog entries under new tag
6e46f3d
@aaronfischer
Setup yuidocs and slim down README in favor of API documentation
386457d
@aaronfischer
Create yuidocs for subcomponents
e23084a
@aaronfischer
Add yuidocs for main component
facd9bf
@aaronfischer
Add further docs
c533440
@aaronfischer
Upgrade ember-cli-mirage to 0.3.2
9d2a570
@aaronfischer
Upgrade to ember-cli 2.13.2
45cef62
@aaronfischer
Upgrade node and .gitignore with ember-try setup
55271f6
@aaronfischer
Merge branch 'upgrade-to-ember-cli-2.13.2' into dynamic-columns
879fd1d
@aaronfischer
Fixing merge error
3f51a82
@aaronfischer
WIP, initial pass at generating the columns based on the modelName
f39cfda
@aaronfischer
Setup a columns array and columnsMap of all potential columns
41826bc
@aaronfischer
Setup a way to automatically render the template based on the model data
3eba20a
@aaronfischer
Setup ember-tabular-cell for rendering specific cell based on column …
683c676 
…data
@aaronfischer
WIP, setup custom override of ember-tabular-cell on a per column.prop…
92f5307 
…erty basis
@aaronfischer
WIP, use find-by and an external config to define when columns need c…
e2da323 
…ustom templates
@aaronfischer
Setup compare-with helper that accepts columnsConfig property and col…
96dc55e 
…umn property
@aaronfischer
Change name to be more contextual
2e3d2b8
@aaronfischer
Setup columnsConfig and automatically merge with the columns array
6ae44e0
@aaronfischer
Fix mock user data
f5942c1
@aaronfischer
Do not require columns array or objects to be ember objects, support …
15e8d10 
…non-KVO compliant
@aaronfischer
Set individual sort properties
38ed3cd
@aaronfischer
Fix scoping issue when setting the sort asc/desc classes
18c8473
@aaronfischer
Change name to column from cell
c020669
@aaronfischer
Setup helper for determining property name
2333f0d
@aaronfischer
WIP, setup way to initialize columns array based on initialized subco…
c5b5b5b 
…mponent columns
@aaronfischer
Setup a helper for determining the passed in column defaults
5b68e3e
@aaronfischer
Remove console.log from columns and add in defaults when column is in…
e68760d 
…itialized automatically
@aaronfischer
Setup way for ember-tabular to know that the custom yields are complete
599efb4
aaronfischer and others added 30 commits July 19, 2018 14:33
@aaronfischer
Setup onFiltering event that fires when an input or dropdown is focus…
daff84c 
…ed within the thead filters
@aaronfischer
Set additional isDestroyed checks
4e1f49d
@aaronfischer
Resolve strange this.get error that can occur on focusFilter
ddd0390
@aaronfischer
Update to ember-power-select 1.10.4
15c8cee
@aaronfischer
Upgrade dependencies
fb4b024
@aaronfischer
Update ember-drag-drop for babel
8ab3240
@aaronfischer
Update pagination-pager for babel
a717664
@aaronfischer
Update action on focus-in to fix deprecation warning
2877c26
@aaronfischer
Remove setting isLoading to false before records are resolved
1778dba
@aaronfischer
Increase min-height slightly to compensate for loading icon
3716367
@aaronfischer
Update ember-power-select to fix, requires ember 2.9+
5b45d48
@aaronfischer
Update changelog
8fb63c8
@aaronfischer
Use ember-basic-dropdown for column-select instead of bootstrap dropd…
1ddf57b 
…own-menu, better positioning
@aaronfischer
Do not renderInPlace, creates spacing issue
d1a9b00
@aaronfischer
Upgrade test suite to ember-qunit (support new syntax)
2a58a3a 
Reference issue #107
@aaronfischer
Continue updating testing coverage for new testing API
52a5114
@aaronfischer
Rewrite testing utils to fit with new testing API
1cfde46
@aaronfischer
WIP, progress converting to new testing API
3da89c7
@aaronfischer
Convert tests to new testing API syntax
93d8d65
@aaronfischer
Fix unit testing
b05307b
@aaronfischer
Update dependencies to fix deprecation warnings
9e3a48c
@aaronfischer
Move power-select to dependencies
8f49f64
@aaronfischer
Downgrade power-select to 1.10.4
f57c0b0
@aaronfischer
Add data-test-selectors to improve selection of table data during tes…
f1c5fc7 
…ting
@aaronfischer
Initial POC, setup way to persist sort/filter/columnOrder via localSt…
69df277 
…orage
@aaronfischer
Refactor to remove sort and filter from persisting, only persist colu…
17918bb 
…mnOrder

Also refactor to use methods that can be overwritten
@aaronfischer
Add tableName prefix and other misc improvements
5cf1a04
@djvoa12
Add verticalPosition below
1125dd7
@morgan
Merge pull request #108 from djvoa12/vertical-position
d0a4b61 
Add verticalPosition below
@morgan
Removing 500 page limit option
27c482e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morgan @aaronfischer @djvoa12