Skip to content

Conversation

@smcoll
Copy link
Contributor

@smcoll smcoll commented Jan 11, 2015

The final allowed type is 'content'.

What do you think about raising a ValueError if type is not in a list of valid options, similar to the implementation of allowed_extensions in get_document_content()?

@caxap
Copy link
Owner

caxap commented Jan 11, 2015

I believe that actual type list can be changed in future. So I will be a little bit painful to track these changes. And that's why I've decided to not add such check.

@smcoll
Copy link
Contributor Author

smcoll commented Jan 11, 2015

Alright, that makes sense.

@caxap
Copy link
Owner

caxap commented Jan 11, 2015

Actually download link has next format https://view-api.box.com/1/sessions/17eb5a85a857467f92b3da5b3c2dd3dd/content. As you can see, it has content trailer.

So we need leave content, or add extra check for download. Something like this:

type = 'content' if type == 'download' else type

@smcoll
Copy link
Contributor Author

smcoll commented Jan 16, 2015

Not sure if i follow; are you saying the API used to have a /download endpoints that was renamed /content? If so, yeah, that conversion might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants