Conversation
…ridstatus Metadata in S3
sonniki
requested changes
May 30, 2025
sonniki
added
PR_for_authors
Pre-commit checks: All checks passed ✅
indrayudd
added
PR_for_reviewers
…_series_as_minimal_unit
sonniki
requested changes
Jun 2, 2025
Contributor
sonniki
left a comment
sonniki
left a comment
There was a problem hiding this comment.
A lot of issues now and in the previous review seem to come from too much copy-and-pasting with not enough reviewing/editing afterwards. Pls keep this in mind in the future. Paying attention to detail keeps the reviewer happy.
sonniki
added
PR_for_authors
Pre-commit checks: All checks passed ✅
indrayudd
added
PR_for_reviewers
sonniki
requested changes
Jun 2, 2025
sonniki
added
PR_for_authors
Pre-commit checks: All checks passed ✅
indrayudd
added
PR_for_reviewers
sonniki
approved these changes
Jun 3, 2025
sonniki
deleted the
TutorTask541_Save_GridStatus_metadata_with_series_as_minimal_unit
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #541