Skip to content

TutorTask539_Reformat_id_field_in_EIA_metadata#540

Merged
sonniki merged 1 commit intomasterfrom
TutorTask539_Reformat_id_field_in_EIA_metadata
May 23, 2025
Merged

TutorTask539_Reformat_id_field_in_EIA_metadata#540
sonniki merged 1 commit intomasterfrom
TutorTask539_Reformat_id_field_in_EIA_metadata

Conversation

@aangelo9
Copy link
Collaborator

Addressing #539.

@aangelo9 aangelo9 self-assigned this May 23, 2025
@aangelo9 aangelo9 force-pushed the TutorTask539_Reformat_id_field_in_EIA_metadata branch from 80ce522 to ce63b24 Compare May 23, 2025 02:56
@aangelo9 aangelo9 requested a review from sonniki May 23, 2025 02:58
@aangelo9
Copy link
Collaborator Author

@sonniki I ran the script with version 2.0 for inspection.

@sonniki
Copy link
Contributor

sonniki commented May 23, 2025

@sonniki I ran the script with version 2.0 for inspection.

Very good for using versioning

@sonniki sonniki merged commit 1c6e6a0 into master May 23, 2025
1 check passed
@sonniki sonniki deleted the TutorTask539_Reformat_id_field_in_EIA_metadata branch May 23, 2025 10:14
@sonniki
Copy link
Contributor

sonniki commented May 30, 2025

@aangelo9 I've missed something before -- we've decided to add the category label (e.g. "electricity") also to the name of the dir with the parameters/facets files. If you look in the s3 bucket, you'll see that for the version 1.0 that dir's name now has "electricity" in it. Could you please modify the script and run it again to have the version 2.0 also with "electricity" in the name? No need for a separate PR for the modified script since it's a minor thing. You can just check it in in #542

@sonniki
Copy link
Contributor

sonniki commented Jun 3, 2025

@aangelo9 I've missed something before -- we've decided to add the category label (e.g. "electricity") also to the name of the dir with the parameters/facets files. If you look in the s3 bucket, you'll see that for the version 1.0 that dir's name now has "electricity" in it. Could you please modify the script and run it again to have the version 2.0 also with "electricity" in the name? No need for a separate PR for the modified script since it's a minor thing. You can just check it in in #542

Nevermind, took care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants