Conversation
sonniki
left a comment
sonniki
left a comment
There was a problem hiding this comment.
Quite a few renaming TODOs require renaming also done in other repos, to which interns don't have access, like cmamp. So that would mean coordinating with one of the mentors or someone else to propagate the change everywhere. Need to keep this in mind (maybe reflect in the TODOs, although it's also kind of implied that these things need to be checked always)
| # TODO(gp): GFI -> get_time_interval | ||
| def get_period(period: str) -> Tuple[pd.Timestamp, pd.Timestamp]: |
There was a problem hiding this comment.
This one is used in other repos too (cmamp, orange)
There was a problem hiding this comment.
Ok. I'll revert and come up with a system to check across the repos.
| # TODO(gp): GFI -> ...varying_asset_tiles | ||
| def build_config_list_varying_universe_tiles( |
| # TODO(gp): GFI -> ...varying_period_tiles | ||
| def build_config_list_varying_tiled_periods( |
| # TODO(gp): GFI -> build_config_list_using_equal_asset_tiles | ||
| def build_config_list_with_tiled_universe( |
| # TODO(gp): GFI -> build_config_list_using_equal_asset_and_period_tiles | ||
| def build_config_list_with_tiled_universe_and_periods( |
| # TODO(gp): GSI. This is for testing and should be in hobject_test.py. | ||
| # TODO(gp): GSI -> check_object_signature | ||
| def test_object_signature( |
| # TODO(gp): GSI. Add unit tests. | ||
| def dassert_increasing_index( |
There was a problem hiding this comment.
Tests already exist:
helpers/helpers/test/test_hpandas.py
Line 3660 in aaacce3
Either an outdated TODO, or need more specs on what tests still have to be added.
| # TODO(gp): GSI. Add more info in case of failures and unit tests. | ||
| def dassert_strictly_increasing_index( |
There was a problem hiding this comment.
Same, tests already exist:
helpers/helpers/test/test_hpandas.py
Line 3731 in aaacce3
Can probably change the TODO to only "Add more info in case of failures", if that's still relevant.
| # TODO(Paul): GSI -> dassert_datetime_indexed_df | ||
| def dassert_time_indexed_df( |
|
|
||
| if __name__ == "main": |
There was a problem hiding this comment.
Why is all of that deleted? By mistake?
There was a problem hiding this comment.
It looked weird (and without comment explaining it) so I thought it was a leftover. pytest collects the tests and we don't use the entrypoint.
Should it be a manual test? (I.e., a disabled pytest?)
There was a problem hiding this comment.
The deleted content is
- the last part of the function
_get_horrible_python_code1(), which provides code for two end-to-end Linter tests - the whole of the function
_get_ipynb_contents1(), which provides code for the test of linting a notebook - the whole of the function
_run_linter(), which actually runs Linter for the tests
It all should be restored, otherwise all the tests will break.
If anything, we should add a TODO to move the code from _get_horrible_python_code1() and _get_ipynb_contents1() to input dirs
2 participants
#547