Fixed full expert graph loading in rca_eval script #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original rca_eval.py script, there was a bug that always passed restricted / more specialized graphs to RCA methods using a causal graph. Hence, even in "Full", where the full expert graph with 94 nodes should have been passed to the methods, a smaller graph with less than 20 nodes was passed - yielding better results.
This bug was found and corrected. The affected results were updated (by the script) and included in the PR.
Will be merged upon acceptance of the corrections on the article @svenpieper.