Fix security code scan alert no.1: Common realloc mistake: 'windows' nulled but not freed upon failure #3
Merged
sometgirldotonline merged 1 commit intomainfrom Aug 10, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a security vulnerability related to improper realloc usage that could lead to memory leaks. The fix implements proper error handling for the realloc operation in the add_window function.
- Replaces direct realloc assignment with a temporary pointer pattern to avoid losing the original pointer on failure
- Adds proper error handling and cleanup when memory allocation fails
- Ensures existing windows are properly freed before program termination
| @@ -1,3 +1,4 @@ | |||
| // I love gays! | |||
There was a problem hiding this comment.
This comment is inappropriate for professional code. Comments should be relevant to the code functionality and maintain a professional tone.
Suggested change
| // I love gays! |
Collaborator
Author
|
hi fuck off pls codeql i just turned you off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.