fix for "set current ampere" feature in Firmware Version 042.0 #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esemlak
approved these changes
Jan 11, 2024
esemlak
left a comment
esemlak
left a comment
There was a problem hiding this comment.
tried manually on my system - works!
|
@cathiele Can you please merge this fix and release a new version? |
|
PLease do not Merge this. Yes, it works for newer Fimrwares and also older Firmwares (below 0.40), but it will write the current to amp instead amx and that will use the flash memory much more! |
|
You could try https://github.com/mpw96/homeassistant-goecharger - there this is fixed properly. |
ey-jo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #84
changed setTmpMaxCurrent to setMaxCurrent.
Bases on API documentation this is fine: the https://github.com/goecharger/go-eCharger-API-v1/blob/master/go-eCharger%20API%20v1%20DE.md