Sensor Enitity Improvments #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us. Otherwise the car_status is not tracked correctly in diagrams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
SensorDeviceClassfor many additional sensors.Also using the predefined Units provided by Homeassistant now. (the only remaining custom unit is
CARD_ID, is that not an integer or enum? Never used it, so no idea).Changing the fallback values when generating the sensors to
NoneforsensorUnit,sensorStateClassandsensorDeviceClass. This results in the sensor entity be ignored by HA.Before this change i.e. the deviceClass of
car_statuswhere set to''resulting in no history for this sensor.