Open
Conversation
Basically I think Thread is too confusing. Process isn't perfect, but I think it's better.
This is mostly for discussion - this is our internal version of trio_test_case with various bells and whistles. I've lightly merged it to keep doctrings. The changes from the internal version are - don't configure logging automatically - unconditionally log around asyncSetUp/asyncTearDown (at INFO level, which lines up well with leaving logging unconfigured by default) instead of making it conditional on running in our CI
dcf59f7 to
d621da6
Compare
Owner
|
See https://github.com/catern/rsyscall/commits/trio-test-case for my revised merge of this. The main thing is simplifying the warnings throwing thing - I think now it's in a nicely upstreamable state (i.e. to unittest.TestCase) while still achieving everything that the colored log messages achieved.
Also, the top answer here is amusing... https://stackoverflow.com/questions/4398967/python-unit-testing-automatically-running-the-debugger-when-a-test-fails
I'd be happy pushing this now, or waiting if we want to look at it more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly for discussion - this is our internal version of
trio_test_case with various bells and whistles. I've lightly merged it
to keep doctrings. The changes from the internal version are
which lines up well with leaving logging unconfigured by default)
instead of making it conditional on running in our CI