Only modify $SESSION when the plugin is actually enabled#476
Merged
cameron1729 merged 1 commit intoMOODLE_400_STABLEfrom Sep 25, 2025
Merged
Only modify $SESSION when the plugin is actually enabled#476cameron1729 merged 1 commit intoMOODLE_400_STABLEfrom
$SESSION when the plugin is actually enabled#476cameron1729 merged 1 commit intoMOODLE_400_STABLEfrom
Conversation
Contributor
|
I think this is possible that this might hook during after_config, during which it might be modified by something like ABConfig, but I think this is good to go. CI is failing, which I havent checked |
Contributor
Author
|
Thanks @Peterburnett The CI failures don't seem related, and I can see from other MRs that CI has been failing in the repo for a while. I tried unit tests locally with this patch and they pass just fine. I'll merge this one, cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.