Fix target url of 'not enough factors' page#251
Closed
Dagefoerde wants to merge 1 commit intocatalyst:masterfrom
Closed
Fix target url of 'not enough factors' page#251Dagefoerde wants to merge 1 commit intocatalyst:masterfrom
Dagefoerde wants to merge 1 commit intocatalyst:masterfrom
Conversation
Contributor
|
thanks @Dagefoerde this got fixed somewhere along the way already so closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am starting work on rebasing #230 / #231 PRs on the new codebase.
As a first step, I factored out a change to
renderer.phpas it does not logically relate to the two new factors. Without the change, it is impossible to log out and re-try login if not enough factors could be supplied. In particular, this is a problem when testing a new factor implementation ;)IIRC this change was originally done by @Laur0r, so I attributed the commit to her.