[T19] Update plugin for compatibility#7
Open
aneno-m-e wants to merge 94 commits intocatalyst:TOTARA_19_STABLEfrom
Open
[T19] Update plugin for compatibility#7aneno-m-e wants to merge 94 commits intocatalyst:TOTARA_19_STABLEfrom
aneno-m-e wants to merge 94 commits intocatalyst:TOTARA_19_STABLEfrom
Conversation
This was done because the core 'import' icon was mapped to the Font Awesome icon 'fa-level-up' which did not look appropriate.
This allows students to view the activity and download their certificate. It also allows teachers to view the list of issued certificates, with the ability to revoke any. This is for Moodle Mobile v3.5.0 (not to be confused with your Moodle site version) and will not work on Mobile versions earlier than this. If you are running a Moodle site on version 3.4 or below you will need to install the local_mobile plugin in order for this to work. If you are running a Moodle site on version 3.0 or below then you will need to upgrade.
This commit is not as vital as the previous one as it does not affect the layout of the PDF.
Also renamed 'Received date' to 'Awarded on'.
Add support to get_users_in_context and delete_data_for_users methods added since 3.4.6 and 3.5.3 and 3.6.
The description strings for the settings prevent copy, prevent print, and prevent modify were mixed up when added with: mdjnelson#180 Add possibility to set default values of activity instance
Make the code easier to read and understand
We should use this instead of our own logic.
The grade item's type was being hard-coded to GRADE_TYPE_VALUE when this isn't always the case.
Increase the vertical spacing after the single button for downloading user’s own certificate. This makes the page look better.
…stomcert into TOTARA_19_STABLE
|
Thanks @aneno-m-e I've created a new branch here based on your first 2 steps and set that as the target. I'm in favor of merging MOODLE_34_BRANCH in, mainly so that there's a version bump, but haven't tested it myself - so I'm leaving this PR open for now. Has this been tested thoroughly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done: