Use lazy evaluation #10
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 17, 2025 14:50
This adds support for updating records in place, using new `update` methods added to the record and record manager base classes. The `update` method has the same smart evaluation of field names based on record classes that the `create` method has. This allows ID or object field names to be used for model refs, and field aliases.
Add a new manager for attachment records (`ir.attachment`) in Odoo. These are intended to be used for uploading/downloading attachments to/from invoices. Invoice attachments will then be attached to invoice emails sent out to customers. The contents of the attachments won't be fetched when querying them from Odoo by default; instead it is intended that the separate `download` method be used to download the attachment contents separately. An `upload` method is also available, to provide an easier to use interface for uploading attachments.
Refactor the record manager `list` and `search` methods, and other methods on record managers, so that it is possible to use lazy evaluation. The `list` and `search` methods now return `ListRecords` and `SearchRecords` objects, which do not perform any requests or processing at first. Calling the `as_ids`, `as_dicts` or `as_records` methods on these objects invokes the API request, but instead of returning lists as with the previous behaviour, generators are returned instead so the user can choose between performing per-item processing lazily on each iteration, or converting to a list to eagerly evaluate everything. This removes the `as_id` and `as_dict` optional parameters from the `list` and `search` methods, which were not possible to express correctly with generators due to bugs in how Mypy handles conditional overloads. Returning a common object that contains separate methods with different, static return types is easier to make compliant with static type checkers.
Collaborator
Author
|
Related Mypy bug for the issues with overloading: python/mypy#12056 |
Callum027
force-pushed
the
callum/add-attachment-support
branch
3 times, most recently
from
43aa7c6 to
025f474
Compare
Callum027
force-pushed
the
callum/add-attachment-support
branch
4 times, most recently
from
b803591 to
72e70f9
Compare
Callum027
force-pushed
the
callum/add-attachment-support
branch
6 times, most recently
from
8c2be27 to
6687f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the record manager
listandsearchmethods, and other methods on record managers, so that it is possible to use lazy evaluation.The
listandsearchmethods now returnListRecordsandSearchRecordsobjects, which do not perform any requests or processing at first. Calling theas_ids,as_dictsoras_recordsmethods on these objects invokes the API request, but instead of returning lists as with the previous behaviour, generators are returned instead so the user can choose between performing per-item processing lazily on each iteration, or converting to a list to eagerly evaluate everything.This removes the
as_idandas_dictoptional parameters from thelistandsearchmethods, which were not possible to express correctly with generators due to bugs in how Mypy handles conditional overloads. Returning a common object that contains separate methods with different, static return types is easier to make compliant with static type checkers.