Open
Conversation
For CARS that has 0 and 360 it could return Greenwich twice.
Before it would take the surrounding slice to allow higer degree interpolation, but if it is coincident, there is no need to interpolate along longitude.
Some aliases can be specified in the datasource descriptor. Use that to guide variables access at the CARS_vars level, so that composite variables can be adjusted as well.
CARS estimate the climatology with harmonics based on the day of year. If doy is not given, assume an array with daily values.
CARS has a mean which is the steady state (no time dependendy), while WOA we use mn. To make it clear let's move to 'climatology' for the climatological value and mean for the steady state.
castelao
force-pushed
the
fix/EdgeInland
branch
from
dfd7219 to
32f5855
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@s-good identified a special case near land that would fail CARS.