-
Notifications
You must be signed in to change notification settings - Fork 9
CSL-1650 Bookshare sponsored import #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klown
wants to merge
19
commits into
development
Choose a base branch
from
feature/CSL-1650-bookshare-sponsored-import
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very rough stab at using the demo Bookshare organizational account, partnerorgdemo@bookshare.org, to import a title for one of its members, namely, partnerorgM1@bookshare.org. Also a first attempt at using the Bookshare error response to create a more informative error message to display when a Bookshare import fails.
After selecting and confirming a Bookshare organizational account member, import the book on behalf of that member.
Also, some code tidying.
TO DO: this uses the Bookshare membership list to select the "Clusive student", but, in future, it will use a list of students. In addition, there is no Period listed for the students. That will need to be set in a future revision.
- Add model for BookshareOrgUserAccount that references a ClusiveUser, and contains the sponsor Bookshare user and the ClusiveUser's Bookshare account identifier (note: many BookshareOrgUserAccounts to one ClusiveUser), - On import from an organizational account, build the list of potential student recipients based on whether they are members of the organizational account in use, - Add batch load of test student accounts with associated Bookshare member accounts.
…okshare-sponsored-import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements import of Bookshare title when using an organizational account, and importing on behalf of a member of the organization.
What's missing:
JIRA: https://castudl.atlassian.net/browse/CSL-1650