Add onDone support for TextView, InputField, and Table (Issue #5)#19
Merged
cassdeckard merged 1 commit intomainfrom Mar 2, 2026
Merged
Add onDone support for TextView, InputField, and Table (Issue #5)#19cassdeckard merged 1 commit intomainfrom
cassdeckard merged 1 commit intomainfrom
Conversation
cassdeckard
force-pushed
the
fix/ondone-enter-simplify
branch
from
9783607 to
53e3760
Compare
- Add OnDone to config.Primitive and config.PageConfig - SetDoneFunc handlers for Enter/Escape on TextView, InputField, Table - ondone-demo.yaml example page; navigation test - Docs: tview-coverage.md, issue-dependencies.md Simple SetDoneFunc-only implementation; relies on tview calling done for Enter/Escape. Escape works via global binding. Table: note that tview does not call SetDoneFunc for Enter when rows are selectable. Made-with: Cursor
cassdeckard
force-pushed
the
fix/ondone-enter-simplify
branch
from
53e3760 to
f3b1660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
onDonesupport (SetDoneFunc) for TextView, InputField, and Table so a template callback runs when the user presses Enter or Escape.Changes
OnDonetoconfig.Primitiveandconfig.PageConfigondone-demo.yamlexample page; navigation acceptance testtview-coverage.md,issue-dependencies.mdImplementation
Simple SetDoneFunc-only implementation; relies on tview calling
donefor Enter/Escape. Escape returns to main via global key binding.Note: tview's Table does not call SetDoneFunc for Enter when rows are selectable (Enter is used for selection). Escape still triggers onDone on selectable tables.