if not Web3.is_address(sys.argv[1]): print("❌ Invalid Ethereum ad… #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dress.", file=sys.stderr) sys.exit(1) address = checksum(sys.argv[1])
Summary
The main CLI in
app.pyhas a bit of duplicated and redundant validation:Web3.is_address(...)(once before and once afterto_checksum_address).if block_a > block_b) appears twice: once inside thetryblock and again immediately afterward, with two slightly different messages.This PR simplifies the validation logic so that:
block_a/block_bswap is performed in a single, clear place.Changes
In
app.py:Address validation
Web3.is_address(sys.argv[1]).Web3.is_address(address)check, which is redundant after checksumming.Block range swap
block_aandblock_bin thetryblock.block_a > block_b, swap and print a single message).if block_a > block_bbranch after thetryblock.Rationale
block_a <= block_b), but with less surprising repetition.Testing