-
-
Notifications
You must be signed in to change notification settings - Fork 139
Mint should check pending proofs and expired quotes regularly #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
based on a conversation had with @callebtc, I’ve updated the PR so that _run_regular_tasks() strictly runs as a simple infinite loop, performing the periodic check and then sleeping. All other logic has been removed from this function as requested to be implemented after a future conversation, thank you |
callebtc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
- please remove the
mint_regular_tasks_enabledtoggle fromsettings.py, we should run the tasks by default - add a simple
while True - remove changes to unrelated files
fixes #596
Summary
Changes
Question
created_time + EXPIRY_SECONDS (5minutes, a fixed lifespan and global timeout)..
Please advise which approach you prefer so I can update accordingly.