Remove paid field in MintQuote #838
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KvngMikey
changed the title
KvngMikey
force-pushed
the
deprecate-paid-in-mint
branch
from
0a00497 to
8e53fe8
Compare
* add migration to clean up overly large witnesses * bump to 0.18.1
KvngMikey
force-pushed
the
deprecate-paid-in-mint
branch
from
8e53fe8 to
975c383
Compare
| "WHERE witness IS NOT NULL AND LENGTH(witness) > 1024" | ||
| ) | ||
|
|
||
| async def m030_remove_paid_from_mint_quote(db: Database): |
Contributor
There was a problem hiding this comment.
Is there a reason we don't just ALTER TABLE DROP COLUMN? They introduced that in SQLite version 3.35.0 back in March of 2021.
Contributor
|
It seems only the postgres tests are failing in CI. I don't see where you are dropping the paid column for postgres, only if conn.type == "SQLITE" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
Summary
This PR completes the deprecation and removal of the legacy paid boolean field in mint_quotes, fully migrating the system to rely on the state field as the single source of truth for quote payment status.
pytest -v.