-
-
Notifications
You must be signed in to change notification settings - Fork 139
Remove Wallet V0 Support #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this. let's get rid of even more code (see comment below)
callebtc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
===========================================
+ Coverage 47.84% 64.25% +16.41%
===========================================
Files 90 90
Lines 10592 10643 +51
===========================================
+ Hits 5068 6839 +1771
+ Misses 5524 3804 -1720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|


Fixes #720
Summary
This PR removes the deprecated v0 wallet API and its helper
(wallet_deprecated.py),along with all related references inv1_api.pyand other wallet modules.PostMeltResponse_deprecatedinv1_api.pyfor older mints).