Skip to content

Conversation

@KvngMikey
Copy link

Fixes #720

Summary

This PR removes the deprecated v0 wallet API and its helper (wallet_deprecated.py), along with all related references in v1_api.py and other wallet modules.

  • All pytest suites (wallet + full repo) pass successfully.
  • Only intentional legacy compatibility remains (like PostMeltResponse_deprecated in v1_api.py for older mints).

@callebtc
Copy link
Collaborator

callebtc commented Nov 4, 2025

love to see it
image

@KvngMikey
Copy link
Author

love to see it image

lol, that's why i'm here.

Copy link
Collaborator

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this. let's get rid of even more code (see comment below)

@callebtc callebtc added enhancement New feature or request wallet About the Nutshell wallet labels Nov 4, 2025
Copy link
Collaborator

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callebtc callebtc added ready Reviewed, tested, ready to merge and removed needs review labels Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.25%. Comparing base (4a4b7f7) to head (ad39580).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
cashu/wallet/v1_api.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #814       +/-   ##
===========================================
+ Coverage   47.84%   64.25%   +16.41%     
===========================================
  Files          90       90               
  Lines       10592    10643       +51     
===========================================
+ Hits         5068     6839     +1771     
+ Misses       5524     3804     -1720     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1denvalu3 a1denvalu3 marked this pull request as draft December 16, 2025 10:55
@a1denvalu3 a1denvalu3 marked this pull request as ready for review December 16, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready Reviewed, tested, ready to merge wallet About the Nutshell wallet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallet: remove v0 support

2 participants