-
Notifications
You must be signed in to change notification settings - Fork 65
NUT-11 + NUT-14: New P2PK/HTLC rules #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This looks good. It would be nice if we could add some test vectors for this and make sure the current ones we have are up to date this this change. |
Have added / tidied / checked test vectors and done some general typo/grammar fixes. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Further to meeting today, I've added a clarifying note that Locktime/Refund multisig conditions cannot be blended. |
Was mistake. But have pr to bring us up to date cashubtc/cdk#1435 |
Appreciate you taking care of it @thesimplekid |
|
Wouldn't be cleaner if we moved multisig test vectors under sig_inputs? |
Although those tests are SIG_INPUTS, they are examples of general multisig conditions. Whether they are SIG_INPUTS or SIG_ALL doesn't change the examples. |
Closes #310
This PR codifies the new P2PK / HTLC rules agreed to bring us in line with Bitcoin HTLC contracts.
Tl;DR:
The main (locktime) pathway remains open. Either locktime or refund pathway can be used after locktime expiry.