-
Notifications
You must be signed in to change notification settings - Fork 67
onchain bitcoin payment method #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| **Melt request**: | ||
|
|
||
| ```bash | ||
| curl -X POST https://mint.host:3338/v1/melt/onchain -d \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to revist this for onchain and we should just do it for all of them while were at it. #37.
But for onchain specifically it make no sense to wait for the melt to confirm and request should return okay once it is received.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to say that a melt quote does not complete until the transaction is confirmed, then yeah. If a completed melt quote means the transaction was broadcast, then it seems fine to wait.
Was that the consensus that the quote stays pending until the transaction is confirmed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to say that a melt quote does not complete until the transaction is confirmed, then yeah. If a completed > melt quote means the transaction was broadcast, then it seems fine to wait.
What if a mint wants to batch then it doesn't work for broadcast even.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to revist this for onchain and we should just do it for all of them while were at it.
Is there a change you suggest I make here? In NUT-05 it says:
"For methods that involve external payments (like Lightning), this call may block until the payment either succeeds or fails. This can take a long time. Make sure to use no (or a very long) timeout when making this call!"
The way this nut is now seems fine as it shows that a "successful melt response" returns the quote as PENDING and NUT-05 is pretty open-ended in that it says, "this call may block".
Co-authored-by: asmo <asmogo@protonmail.com>
Co-authored-by: asmo <asmogo@protonmail.com>
Uh oh!
There was an error while loading. Please reload this page.