Split mint mod.rs into separate trait modules #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the large monolithic mod.rs file into separate files, each containing a database trait and its corresponding transaction trait: - proofs.rs: MintProofsTransaction + MintProofsDatabase - keys.rs: MintKeyDatabaseTransaction + MintKeysDatabase - quotes.rs: MintQuotesTransaction + MintQuotesDatabase - signatures.rs: MintSignatureTransaction + MintSignaturesDatabase - keyvalue.rs: KVStoreTransaction + KVStoreDatabase + KVStore - saga.rs: SagaTransaction + SagaDatabase - completed_operations.rs: CompletedOperationsTransaction + CompletedOperationsDatabase The mod.rs now only contains struct definitions, migrations, and the main MintDatabase/MintTransaction/DbTransactionFinalizer impls.
crodas
force-pushed
the
feature/split-mod-file-sql-common
branch
from
740ce27 to
216ecdd
Compare
2 tasks
crodas
force-pushed
the
feature/split-mod-file-sql-common
branch
from
fb52ac4 to
4e599d0
Compare
crodas
force-pushed
the
feature/split-mod-file-sql-common
branch
from
4e599d0 to
cdfc407
Compare
thesimplekid
reviewed
Jan 4, 2026
Co-authored-by: tsk <tsk@thesimplekid.com>
Co-authored-by: tsk <tsk@thesimplekid.com>
thesimplekid
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the large monolithic mod.rs file into separate files, each containing a database trait and its corresponding transaction trait:
The mod.rs now only contains struct definitions, migrations, and the main MintDatabase/MintTransaction/DbTransactionFinalizer impls.
closes: #1489
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing