Permit installing JDBC modules outside JooqModule #3611
Merged
+121
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregory-block
deleted the
tgregory-jooq-module-support-existing-jdbc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JooqModulecurrently does not permit using any JDBC configuration other than the defaultJdbcModule. This is a particular problem for services which use Vitess, which are forced to copy most ofJdbcModuleinto their own code so they can install alternative JDBC modules.This PR adds a bool parameter that prevents
JooqModulefrom installingJdbcModuleto support those use cases. The default matches the current behavior, so this change is backwards compatible.Testing Strategy
Added an integration test exercising
jdbcModuleAlreadySetupChecklist
Thank you for contributing to Misk! 🎉