Skip to content

Conversation

@engbenny
Copy link

Description

Adds support for sending binary messages over websockets. Also corrects some typos in comments.

Testing Strategy

Added new unit tests.

Definition of Done

  • I plan on utilizing this in a side project I'm working on, I'll confirm it works locally

Rollout Strategy and Risk Mitigation

  • Minimal risk since this was a feature previously unsupported - threw NotImplementedError

Checklist

  • I have reviewed this PR with relevant experts and/or impacted teams.
  • I have added tests to have confidence my changes work as expected.
  • I have a rollout plan that minimizes risks and includes monitoring for potential issues.

Adds support for sending binary messages over websockets.
Also corrects some typos in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant