Skip to content

update StartVitessDatabaseTask to accept classpath #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yyuan-squareup wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update StartVitessDatabaseTask to accept classpath #3455

yyuan-squareup wants to merge 2 commits into from

Conversation

@yyuan-squareup
Copy link
Collaborator

@yyuan-squareup yyuan-squareup commented Oct 8, 2025 •
edited
Loading

  • Revisit the implementation and test

Description

Testing Strategy

Checklist

  • I have reviewed this PR with relevant experts and/or impacted teams.
  • I have added tests to have confidence my changes work as expected.
  • I have a rollout plan that minimizes risks and includes monitoring for potential issues.

Thank you for contributing to Misk! 🎉

adrw
adrw approved these changes Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@adrw adrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@adrw adrw marked this pull request as ready for review December 5, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrw adrw adrw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yyuan-squareup @adrw