-
Notifications
You must be signed in to change notification settings - Fork 198
SRE-627: match hibernate exception handling in jooq #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vitaly-block
wants to merge
11
commits into
cashapp:master
Choose a base branch
from
vitaly-block:SRE-627-match-hibernate-exception-handling-in-jooq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SRE-627: match hibernate exception handling in jooq #3452
vitaly-block
wants to merge
11
commits into
cashapp:master
from
vitaly-block:SRE-627-match-hibernate-exception-handling-in-jooq
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajon
reviewed
Oct 8, 2025
aparajon
reviewed
Oct 8, 2025
|
|
||
| private fun isMessageRetryable(th: SQLException) = | ||
| isConnectionClosed(th) || | ||
| isVitessTransactionNotFound(th) || |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a bit of other retryable message strings that we may want to include here that are in our JSC component. Perhaps worth a follow-up PR if we want to keep this PR simpler
aparajon
reviewed
Oct 8, 2025
2b8183c to
f6cdea1
Compare
* match hibernate exception handling in jooq * do nto support cockroachdb
f104796 to
2319b9a
Compare
7f535aa to
46eb183
Compare
46eb183 to
9a0e5ab
Compare
adrw
reviewed
Oct 23, 2025
adrw
reviewed
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist hibernate-like exception handling to misk-jdbc to cover other providers with the same logic
Description
Refactored the TransactionRetryHandler to make database exception retry logic specific to the database type being used.
Database-Specific Retry Logic: Retryable exceptions are now only checked for the configured database type:
API Changes
New Constructor: Added convenient TransactionRetryHandler(qualifierName, databaseType) constructor for easy database type-specific configuration
Backward Compatibility: Existing constructors and APIs remain unchanged
There should be no breaking changes, existing code should work:
Testing Strategy
New test cases included, https://gradle.com/s/7wbp6xzb5nt4q
Checklist