Global Recipe Completion #3012
Open
Global Recipe Completion #3012
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When completions happen with a local justfile present, global recipes are ignored. All this does is allow for them to appear. A better strategy may be to consume the `-g|--global-justfile` argument and use that to inspire the autocomplete. However, since running `just <GLOBAL_RECIPE>` without the `-g` flag works, I think this may violate the best approach.
Contributor
That does not work for me |
Author
You are right, I forgot I had fallback on the justfile! It may be better to consume the |
If the preceding flag is `--global-justfile | -g`, the recipe completions will now list the global recipes. We do not need path checking since global file resolution is already implemented.
Author
|
This should work better now. It aligns better with existing behaviours and the presence of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When completions happen with a local justfile present, global recipes are ignored. All this does is allow for them to appear. A better strategy may be to consume the
-g|--global-justfileargument and use that to inspire the autocomplete. However, since runningjust <GLOBAL_RECIPE>without the-gflag works, I think this may violate the best approach.