Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates both the testing libraries and the underlying PEG.js version (to the current latest, 0.10). Testing libraries were updated because the Mocha version used was not producing any output on my system, and so this was necessary to verify that the PEG.js upgrade worked correctly.
Because the underlying API and options of PEG.js itself (which are passed through) have changed, this is a breaking change and therefore would require a bump of this library's version number to
0.3.0. For that reason, I've also rolled in abuildParser->generateAPI naming change to mirror that in PEG.js itself, since it will be a breaking release anyway.All tests pass. I have not done any additional manual testing outside of the automated tests.