added gui

[KP2048]

No description provided.

[caseif]

Can you rebase this on the latest HEAD? (I just merged @SundayReds's hid fix.)

[caseif]

I'm not currently able to build this branch due to compilation errors in Borealis - I suspect this is an incompatibility with latest libnx. Would you be able to update the submodule to the latest main revision?

[KP2048]

I’m using nadrino’s fork of borealis. It compiles fine on the version of libnx I’m using which should be the latest as I’m doing it in a docker container

[KP2048]

And I already implemented the changes from @SundayReds’s pr
So I’ll just rebase it keeping my version

[KP2048]

can you list the compilation errors?

[KP2048]

also can you try merging the docker one first and ill rebase it into the gui branch,
that way you have a clean environment that is confirmed working

[caseif]

This is the error I'm currently getting:

/home/max/git/skymm-nx/borealis/library/lib/swkbd.cpp: In function 'SwkbdConfig brls::createSwkbdBaseConfig(std::string, std::string, int, std::string)':
/home/max/git/skymm-nx/borealis/library/lib/swkbd.cpp:45:5: error: 'swkbdConfigSetStringLenMaxExt' was not declared in this scope; did you mean 'swkbdConfigSetStringLenMax'?
   45 |     swkbdConfigSetStringLenMaxExt(&config, 1);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     swkbdConfigSetStringLenMax

I'll look into merging the Docker PR; I've personally never used it or any project that does so I'll need to look further into whether it's something I'd want to merge in.

Also, for future comments can you try to consolidate them into one or two? My phone gets a notification for every email as it comes in so it tends to blow up a bit when there are multiple. :)

[KP2048]

Basically docker makes a container so that stuff like compilation has exactly the same environment for anyone that wants to build it

[KP2048]

Btw what version is your libnx? I want to verify that you are compiling on the same version as me

[KP2048]

I have 4.0.0-1

[KP2048]

the thing is, a lot of things have changed in borealis since I created this, so I'd have to rewrite some things if I were to update borealis

[KP2048]

a workaround is that i could fork nadrino's fork and fix the compile errors you are having

[caseif]

I'm on libnx 4.1.3-1 from the dkp-libs repo.

What's the reason for using a fork? If possible I think it would be better to track the main repository given that it's seemingly maintained. I also would prefer to track the latest version so that we're not stuck on a specific version with extra work required to upgrade.

Also:

Also, for future comments can you try to consolidate them into one or two? My phone gets a notification for every email as it comes in so it tends to blow up a bit when there are multiple. :)

[KP2048]

right, well again i would have to rewrite some code because things have changed in borealis but if you insist, I can update things

[KP2048]

oh and when i say rewrite things, it means REWRITE EVERYTHING...
they basically ripped out all the old code and rewrote the library from scratch.

[KP2048]

it should now compile

[SundayReds]

I'll look into merging the Docker PR; I've personally never used it or any project that does so I'll need to look further into whether it's something I'd want to merge in.

perhaps slightly off-tangent, but I can vouch for the usefulness of having a docker environment (@Witherking25 's one seems to contain extra configurations specific to the VScode IDE extension though - while convenient for VScode users, maybe a pure dockerfile would be more standard in a repo). It allows us to preserve a environment container in which the code will definitely compile, irrespective of the installed libraries/package versions on the local machine. This protects the codebase from being subject to the whims and mercies of third-party dependencies like libnx, exactly like what happened in #8.

The downside is that we would need to take up some GB's of extra space on local disk just to download the docker image.

[KP2048]

Yea I’ll probably change it to just a Dockerfile in the repo root

[caseif]

Sorry for the radio silence on this. It's been really crazy at work lately and if I'm being honest I haven't had too much drive to do much hobby stuff after hours. I'll try to go through your changes again this weekend if I can find time.

Is there some documentation of the changes in Borealis between the version you forked and latest? I still don't think I'm too keen to rely on anything other than upstream but I'd like to get a feel for how expansive the changes are exactly.

[KP2048]

The latest borealis is a complete rewrite and is currently unfinished so it doesn’t have everything implemented. My fork is before the rewrite, but I updated the code to be compatible with the latest libnx

[KP2048]

And unfortunately because the latest borealis is unfinished, there is no documentation

[KP2048]

Ready for merge

[KP2048]

https://github.com/natinusala/borealis/wiki
the official documentation hasn’t been updated to the wip rewrite so it works with my fork

[KP2048]

My fork is basically the legacy branch of borealis with some bug fixes
compare legacy branch with fork

[KP2048]

Will this get merged?

[fennectech]

it seems the original author has disappeared, might be best to just make your own fork "Skyrim Mod Manager" or something.

[KP2048]

Fair enough, I might just do that