feat: add file upload/download support to Daytona provider #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement upload_file() and download_file() methods - Use Daytona SDK's fs.upload_file() and fs.download_file() - Add path validation for security (prevent path traversal) - Fix timeout issue: pass config.timeout_seconds to SDK (default 120s) - Add comprehensive integration test - Verified with manual testing Fixes timeout issues where Daytona SDK's 60s default was too short
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
upload_file()anddownload_file()methods for Daytona providertimeout_secondsfrom config to SDKChanges
sandboxes/providers/daytona.pyupload_file()method using Daytona SDK'sfs.upload_file()download_file()method using Daytona SDK'sfs.download_file()config.timeout_secondsto SDK (defaults to 120s instead of 60s)tests/test_integration_daytona.pytest_file_upload_download()integration testTesting
Context
This brings Daytona provider to feature parity with E2B, Hopx, and Cloudflare providers, all of which support file operations. The Daytona SDK already has the necessary methods - this PR just exposes them through our unified interface.