Retrieve `imagetype` from casa images by r-xue · Pull Request #532 · casangi/xradio

r-xue · 2026-01-24T15:33:56Z

No description provided.

…nfo")` instead of `image.info()["imageinfo"]`.

codecov · 2026-01-24T15:43:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

r-xue · 2026-01-24T15:43:38Z

tests/unit/image/test_image.py

    raise TypeError(f"Type {type(obj)} not serializable")


+def clean_path_logic(text: str) -> str:


This is mainly a workaround to address the absolute path presentation in the retrieved subtable keyword value. I only became aware of this behavior until @tnakazato recently ran into a path issue, when manually registering a subtable (see this PR)

r-xue · 2026-01-24T15:46:45Z

tests/unit/image/test_image.py

+                    # the imagetype.
+                    c2["imageinfo"]["imagetype"] = "Intensity"
                    self.dict_equality(c2, c1, "got", "expected")
+        with open_table_ro(self.outname()) as tb1:


Since im.info()["imageinfo"]["imagetype"] might not be reliable for metadata cross-checking, see #530 (comment), I now add another block to check individual keyword values from the image main table.

r-xue · 2026-01-24T16:12:27Z

src/xradio/image/_util/_casacore/xds_from_casacore.py

    coord_dict = copy.deepcopy(meta_dict["coordinates"])
    attrs = {}
-    attrs[_image_type] = image.info()["imageinfo"]["imagetype"]
+


With 8505723 now added, this change might be unnecessary to get the test working again.

I have to admit that I haven't fully understood how the 'imagetype' value persists during a round-trip conversion. @dmehring may need to look at the logic here, or perhaps we need to revert. I mainly wanted to emphasize that 'imagetype' retrieved from casacore image.info() could potentially introduce some confusion.

r-xue · 2026-01-25T03:24:56Z

src/xradio/_utils/_casacore/casacore_from_casatools.py

            else:
                image_metadata = {"imagetype": "Intensity", "objectname": ""}

+        image_metadata["imagetype"] = _validate_image_type(


Hi @FedeMPouzols, this might be a more precise "reverse-engineering" of the python-casacore image.imageinfo underlying logic vs 78389d.

With this, imagetype retrieval for both the input and output image would end up as "Intensity" (though that may not be what we actually desired). At least this makes the casatools wrapper API behave identically to the python-casacore one.

Aha, yes, in that commit I just tried to bring things in sync again after the recent test failures. But I see there were indeed more complications behind this and test_metadata had been passing by "luck".

I guess what remains to be figured out is whether to use imageinfo() or only directly the keywords. Perhaps long-term we should try to get support (standardize) for sky in python-casacore/casacore? Otherwise this confusion point will be there hidden and waiting to bite users.

Definitely from the code there doesn't seem to be any chance for "sky" to work via imageinfo(): https://github.com/casacore/casacore/blob/master/images/Images/ImageInfo.cc#L325 / https://github.com/casacore/casacore/blob/master/images/Images/ImageInfo.cc#L244-L254 / https://github.com/casacore/casacore/blob/master/images/Images/ImageInfo.cc#L75-L77 / https://github.com/casacore/casacore/blob/master/images/Images/ImageInfo.cc#L195-L242 /

…xds_from_casacore.py` and `tests/unit/image/test_image.py`.

r-xue · 2026-01-25T03:48:59Z

src/xradio/image/_util/_casacore/xds_from_casacore.py

-    else:
-        attrs[_image_type] = image_type.lower()
-
+    attrs[_image_type] = image.info()["imageinfo"]["imagetype"]


Revert this to the original line since it's not essential to fix the original testing-related issue.

r-xue · 2026-01-25T05:31:18Z

tests/unit/image/test_image.py

-                    # from the image table, or a non-standard value of "imagetype" was
-                    # written into that keyword, image.info() will return "Intensity" as
-                    # the imagetype.
-                    c2["imageinfo"]["imagetype"] = "Intensity"


Forcing "Intensity" is not necessary now, as the casatools wrapper will behave identically to python-casacore API. Revert back.

Copilot

Pull request overview

This PR enhances the CASA image handling in xradio by adding validation for imagetype values to match python-casacore's behavior. When reading CASA images, any non-standard imagetype values (e.g., 'sky') are now normalized to valid casacore ImageInfo enum values, with invalid types defaulting to 'Intensity'.

Changes:

Added validation logic for imagetype values when reading CASA images to match python-casacore behavior
Enhanced test infrastructure to handle path variations in metadata comparisons
Extended metadata round-trip testing to include table keywords validation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/xradio/_utils/_casacore/casacore_from_casatools.py	Added `_VALID_IMAGE_TYPES` constant and `_validate_image_type()` function; updated `imageinfo()` method to validate imagetype values against casacore enum
tests/unit/image/test_image.py	Added `clean_path_logic()` helper for path normalization; enhanced `dict_equality()` to handle path differences; extended `test_metadata()` to validate table keywords

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/unit/image/test_image.py

Copilot · 2026-01-25T05:37:23Z

src/xradio/_utils/_casacore/casacore_from_casatools.py

+    -----
+    Validation is case-insensitive. The returned string uses the
+    canonical capitalization from the casacore ImageInfo enum.
+    """


The function calls value.lower() without checking if value is a string. If the imagetype keyword in a CASA image table contains a non-string value (e.g., None or an integer), this will raise an AttributeError. Consider adding type checking: if not isinstance(value, str): return "Intensity" at the beginning of the function to handle edge cases more gracefully.

Suggested change

"""

"""

if not isinstance(value, str):

return "Intensity"

src/xradio/_utils/_casacore/casacore_from_casatools.py

…r keyword-based image metadata comparisons

r-xue added 2 commits January 24, 2026 08:30

Retrieve imagetype from CASA images using `table.getkeyword("imagei…

ea5774b

…nfo")` instead of `image.info()["imageinfo"]`.

Add a subtable path cleaning logic in ImageBase.dict_equality

8505723

r-xue commented Jan 24, 2026

View reviewed changes

r-xue requested a review from dmehring January 24, 2026 16:12

Add imagetype validation to the return of image.imageinfo method

0d1b3e1

r-xue commented Jan 25, 2026

View reviewed changes

Revert some unnecessary changes to `src/xradio/image/_util/_casacore/…

fc6ec4c

…xds_from_casacore.py` and `tests/unit/image/test_image.py`.

r-xue commented Jan 25, 2026

View reviewed changes

r-xue requested a review from FedeMPouzols January 25, 2026 05:31

r-xue marked this pull request as ready for review January 25, 2026 05:32

Copilot AI review requested due to automatic review settings January 25, 2026 05:32

Copilot started reviewing on behalf of r-xue January 25, 2026 05:32 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

r-xue force-pushed the retrieve-imagetype-from-casa-images branch from 3035319 to ecef7cc Compare January 25, 2026 17:57

Add new options in the dict_equality method; fix the wrong input fo…

1750c81

…r keyword-based image metadata comparisons

r-xue force-pushed the retrieve-imagetype-from-casa-images branch from ecef7cc to 1750c81 Compare January 25, 2026 19:54

Jan-Willem merged commit 29a3679 into casangi:main Jan 27, 2026
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retrieve `imagetype` from casa images#532

Retrieve `imagetype` from casa images#532
Jan-Willem merged 5 commits intocasangi:mainfrom
r-xue:retrieve-imagetype-from-casa-images

r-xue commented Jan 24, 2026

Uh oh!

codecov bot commented Jan 24, 2026 •

edited

Loading

Uh oh!

r-xue Jan 24, 2026

Uh oh!

r-xue Jan 24, 2026 •

edited

Loading

Uh oh!

r-xue Jan 24, 2026

Uh oh!

r-xue Jan 25, 2026 •

edited

Loading

Uh oh!

FedeMPouzols Jan 27, 2026

Uh oh!

r-xue Jan 25, 2026

Uh oh!

r-xue Jan 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 25, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		raise TypeError(f"Type {type(obj)} not serializable")


		def clean_path_logic(text: str) -> str:

Conversation

r-xue commented Jan 24, 2026

Uh oh!

codecov bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

r-xue Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

r-xue Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r-xue Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

r-xue Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FedeMPouzols Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

r-xue Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

r-xue Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 24, 2026 •

edited

Loading

r-xue Jan 24, 2026 •

edited

Loading

r-xue Jan 25, 2026 •

edited

Loading