Skip to content

Add itrs to AllowedUvwFrames#477

Open
sjperkins wants to merge 4 commits intomainfrom
expand-uvw-frames
Open

Add itrs to AllowedUvwFrames#477
sjperkins wants to merge 4 commits intomainfrom
expand-uvw-frames

Conversation

@sjperkins
Copy link
Copy Markdown
Collaborator

@sjperkins sjperkins commented Sep 4, 2025

This PR adds itrs to AllowedUvwFrames as it would allow a topocentric frame for new MSv4 datasets, rather than from a perspective of supporting legacy MSv2 datasets.

It might make sense to support other frames from SkyCoordFrames, but this needs further investigation

# Taken from the list of astropy built-in frame classes: https://docs.astropy.org/en/stable/coordinates/index.html
AllowedSkyCoordFrames = Literal[
"icrs",
"fk5",
"fk4",
"fk4noterms",
"galactic",
"galactocentric",
"supergalactic",
"altaz",
"hadec",
"gcrs",
"cirs",
"itrs",
"hcrs",
"teme",
"tete",
"precessedgeocentric",
"geocentricmeanecliptic",
"barycentricmeanecliptic",
"heliocentricmeanecliptic",
"geocentrictrueecliptic",
"barycentrictrueecliptic",
"heliocentrictrueecliptic",
"heliocentriceclipticiau76",
"custombarycentricecliptic",
"lsr",
"lsrk",
"lsrd",
"galacticlsr",
]

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant