33 update toolviper to use gh actions templates public workflows#34
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR migrates GitHub Actions workflows from local template files to centralized templates hosted in the nrao/gh-actions-templates-public repository. This consolidation reduces code duplication and centralizes workflow maintenance.
- All workflow files now reference external templates from
nrao/gh-actions-templates-publicinstead of local templates incasangi/toolviper - Local template files are removed as they are no longer needed
- Job names updated for clarity (e.g.,
call-testing-linux→call-testing-ipynb,call-testing-macos)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/run-ipynb.yml |
Updated to use external template and renamed job to call-testing-ipynb |
.github/workflows/python-testing-macos.yml |
Updated to use external template and renamed job to call-testing-macos |
.github/workflows/python-testing-linux.yml |
Updated to use external template from new repository |
.github/workflows/python-testing-integration.yml |
Updated to use external template from new repository |
.github/workflows/python-publish.yml |
Updated to use external template from new repository |
.github/workflows/black.yml |
Updated to use external template from new repository |
.github/workflows/run-ipynb-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/python-testing-macos-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/python-testing-linux-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/python-testing-integration-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/python-testing-casatools-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/python-publish-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/python-publish-cpp-template.yml |
Deleted local template (now centralized externally) |
.github/workflows/black-template.yml |
Deleted local template (now centralized externally) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/run-ipynb.yml
Outdated
| call-testing-linux: | ||
| uses: casangi/toolviper/.github/workflows/run-ipynb-template.yml@main | ||
| call-testing-ipynb: | ||
| uses: nrao/gh-actions-templates-public/.github/workflows/run-ipynb-template.yml@2-ipynb-workflow-is-getting-stuck |
There was a problem hiding this comment.
The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.
| uses: nrao/gh-actions-templates-public/.github/workflows/run-ipynb-template.yml@2-ipynb-workflow-is-getting-stuck | |
| uses: nrao/gh-actions-templates-public/.github/workflows/run-ipynb-template.yml@main |
| call-testing-linux: | ||
| uses: casangi/toolviper/.github/workflows/python-testing-macos-template.yml@main No newline at end of file | ||
| call-testing-macos: | ||
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-macos-template.yml@2-ipynb-workflow-is-getting-stuck No newline at end of file |
There was a problem hiding this comment.
The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-macos-template.yml@2-ipynb-workflow-is-getting-stuck | |
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-macos-template.yml@main |
|
|
||
| call-testing-linux: | ||
| uses: casangi/toolviper/.github/workflows/python-testing-linux-template.yml@main | ||
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-linux-template.yml@2-ipynb-workflow-is-getting-stuck |
There was a problem hiding this comment.
The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-linux-template.yml@2-ipynb-workflow-is-getting-stuck | |
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-linux-template.yml@main |
| jobs: | ||
| test: | ||
| uses: casangi/toolviper/.github/workflows/python-testing-integration-template.yml@main | ||
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-integration-template.yml@2-ipynb-workflow-is-getting-stuck |
There was a problem hiding this comment.
The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-integration-template.yml@2-ipynb-workflow-is-getting-stuck | |
| uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-integration-template.yml@main |
.github/workflows/python-publish.yml
Outdated
|
|
||
| call-publish: | ||
| uses: casangi/toolviper/.github/workflows/python-publish-template.yml@main | ||
| uses: nrao/gh-actions-templates-public/.github/workflows/python-publish-template.yml@2-ipynb-workflow-is-getting-stuck |
There was a problem hiding this comment.
The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.
| uses: nrao/gh-actions-templates-public/.github/workflows/python-publish-template.yml@2-ipynb-workflow-is-getting-stuck | |
| uses: nrao/gh-actions-templates-public/.github/workflows/python-publish-template.yml@main |
.github/workflows/black.yml
Outdated
| jobs: | ||
| call-testing-linux: | ||
| uses: casangi/toolviper/.github/workflows/black-template.yml@main No newline at end of file | ||
| uses: nrao/gh-actions-templates-public/.github/workflows/black-template.yml@2-ipynb-workflow-is-getting-stuck No newline at end of file |
There was a problem hiding this comment.
The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.
| uses: nrao/gh-actions-templates-public/.github/workflows/black-template.yml@2-ipynb-workflow-is-getting-stuck | |
| uses: nrao/gh-actions-templates-public/.github/workflows/black-template.yml@main |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -3,4 +3,4 @@ on: [push, pull_request] | |||
|
|
|||
| jobs: | |||
| call-testing-linux: | |||
There was a problem hiding this comment.
The job name "call-testing-linux" is inconsistent with the purpose of this workflow, which runs the black code formatter. Consider renaming this job to something more descriptive like "call-black-linting" or "call-lint" to better reflect its actual functionality.
| call-testing-linux: | |
| call-black-linting: |
No description provided.