Skip to content

33 update toolviper to use gh actions templates public workflows#34

Merged
Jan-Willem merged 3 commits intomainfrom
33-update-toolviper-to-use-gh-actions-templates-public-workflows
Jan 12, 2026
Merged

33 update toolviper to use gh actions templates public workflows#34
Jan-Willem merged 3 commits intomainfrom
33-update-toolviper-to-use-gh-actions-templates-public-workflows

Conversation

@Jan-Willem
Copy link
Copy Markdown
Member

No description provided.

@Jan-Willem Jan-Willem linked an issue Jan 9, 2026 that may be closed by this pull request
@Jan-Willem Jan-Willem requested a review from Copilot January 9, 2026 15:15
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates GitHub Actions workflows from local template files to centralized templates hosted in the nrao/gh-actions-templates-public repository. This consolidation reduces code duplication and centralizes workflow maintenance.

  • All workflow files now reference external templates from nrao/gh-actions-templates-public instead of local templates in casangi/toolviper
  • Local template files are removed as they are no longer needed
  • Job names updated for clarity (e.g., call-testing-linuxcall-testing-ipynb, call-testing-macos)

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
.github/workflows/run-ipynb.yml Updated to use external template and renamed job to call-testing-ipynb
.github/workflows/python-testing-macos.yml Updated to use external template and renamed job to call-testing-macos
.github/workflows/python-testing-linux.yml Updated to use external template from new repository
.github/workflows/python-testing-integration.yml Updated to use external template from new repository
.github/workflows/python-publish.yml Updated to use external template from new repository
.github/workflows/black.yml Updated to use external template from new repository
.github/workflows/run-ipynb-template.yml Deleted local template (now centralized externally)
.github/workflows/python-testing-macos-template.yml Deleted local template (now centralized externally)
.github/workflows/python-testing-linux-template.yml Deleted local template (now centralized externally)
.github/workflows/python-testing-integration-template.yml Deleted local template (now centralized externally)
.github/workflows/python-testing-casatools-template.yml Deleted local template (now centralized externally)
.github/workflows/python-publish-template.yml Deleted local template (now centralized externally)
.github/workflows/python-publish-cpp-template.yml Deleted local template (now centralized externally)
.github/workflows/black-template.yml Deleted local template (now centralized externally)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

call-testing-linux:
uses: casangi/toolviper/.github/workflows/run-ipynb-template.yml@main
call-testing-ipynb:
uses: nrao/gh-actions-templates-public/.github/workflows/run-ipynb-template.yml@2-ipynb-workflow-is-getting-stuck
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.

Suggested change
uses: nrao/gh-actions-templates-public/.github/workflows/run-ipynb-template.yml@2-ipynb-workflow-is-getting-stuck
uses: nrao/gh-actions-templates-public/.github/workflows/run-ipynb-template.yml@main

Copilot uses AI. Check for mistakes.
call-testing-linux:
uses: casangi/toolviper/.github/workflows/python-testing-macos-template.yml@main No newline at end of file
call-testing-macos:
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-macos-template.yml@2-ipynb-workflow-is-getting-stuck No newline at end of file
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.

Suggested change
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-macos-template.yml@2-ipynb-workflow-is-getting-stuck
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-macos-template.yml@main

Copilot uses AI. Check for mistakes.

call-testing-linux:
uses: casangi/toolviper/.github/workflows/python-testing-linux-template.yml@main
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-linux-template.yml@2-ipynb-workflow-is-getting-stuck
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.

Suggested change
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-linux-template.yml@2-ipynb-workflow-is-getting-stuck
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-linux-template.yml@main

Copilot uses AI. Check for mistakes.
jobs:
test:
uses: casangi/toolviper/.github/workflows/python-testing-integration-template.yml@main
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-integration-template.yml@2-ipynb-workflow-is-getting-stuck
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.

Suggested change
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-integration-template.yml@2-ipynb-workflow-is-getting-stuck
uses: nrao/gh-actions-templates-public/.github/workflows/python-testing-integration-template.yml@main

Copilot uses AI. Check for mistakes.

call-publish:
uses: casangi/toolviper/.github/workflows/python-publish-template.yml@main
uses: nrao/gh-actions-templates-public/.github/workflows/python-publish-template.yml@2-ipynb-workflow-is-getting-stuck
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.

Suggested change
uses: nrao/gh-actions-templates-public/.github/workflows/python-publish-template.yml@2-ipynb-workflow-is-getting-stuck
uses: nrao/gh-actions-templates-public/.github/workflows/python-publish-template.yml@main

Copilot uses AI. Check for mistakes.
jobs:
call-testing-linux:
uses: casangi/toolviper/.github/workflows/black-template.yml@main No newline at end of file
uses: nrao/gh-actions-templates-public/.github/workflows/black-template.yml@2-ipynb-workflow-is-getting-stuck No newline at end of file
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is referencing a branch named '2-ipynb-workflow-is-getting-stuck' which appears to be a development or issue-specific branch rather than a stable reference like 'main' or a version tag. Using a development branch reference in production workflows can lead to unexpected behavior if that branch is modified, rebased, or deleted. Consider using a stable branch reference (e.g., 'main') or a specific version tag once the changes are finalized.

Suggested change
uses: nrao/gh-actions-templates-public/.github/workflows/black-template.yml@2-ipynb-workflow-is-getting-stuck
uses: nrao/gh-actions-templates-public/.github/workflows/black-template.yml@main

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -3,4 +3,4 @@ on: [push, pull_request]

jobs:
call-testing-linux:
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job name "call-testing-linux" is inconsistent with the purpose of this workflow, which runs the black code formatter. Consider renaming this job to something more descriptive like "call-black-linting" or "call-lint" to better reflect its actual functionality.

Suggested change
call-testing-linux:
call-black-linting:

Copilot uses AI. Check for mistakes.
@Jan-Willem Jan-Willem merged commit 7de9756 into main Jan 12, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ToolVIPER to use gh-actions-templates-public workflows

3 participants